chore(p/grc20): Distinct Event Types for GRC20 Functions #2749
Conversation
notJoon
requested review from
deelawn and
gfanton
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2749 +/- ##
==========================================
+ Coverage 60.90% 60.92% +0.01%
==========================================
Files 564 564
Lines 75273 75273
==========================================
+ Hits 45848 45859 +11
+ Misses 26055 26044 -11
Partials 3370 3370
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@notJoon, can you elaborate more on why you want to do this? |
|
The ERC20 spec mentions that a mint function should emit a transfer from a zero address to the address receiving new tokens (see Since we're actively working on the GRC20 package, let me know how crucial this is to you; we (or you) can try to implement what I mentioned above in the next iteration. It mentions nothing about the burn case, so I guess we can do whatever we want there. cc @moul |
|
Can you please merge |
# Description Current event(emit) code in p/grc721 really doesn't emits event. Therefore, modified code to emit the events. And similar to #2749, made event type for each function to be unique. <!-- please provide a detailed description of the changes made in this pull request. --> <details><summary>Contributors' checklist...</summary> - [ ] Added new tests, or not needed, or not feasible - [ ] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [ ] Updated the official documentation or not needed - [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [ ] Added references to related issues and PRs - [ ] Provided any useful hints for running manual tests </details>
Description
Currently, the event type for grc20 is uniformly set to
TrasferEvent(execpt forApprovalfunction), which necessitated making RPC calls to check every block.Therefore, I have modified it by adding event types for each function to distinguish them from one another.
In this case, we can reduce the number of RPC calls by retrieving data only when the target event type occurs.
Contributors' checklist...
BREAKING CHANGE: xxxmessage was included in the description